1950123 - Tabs closed as part of a deleted tab group cannot have their history entries forgotten (in Firefox View or elsewhere)

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Jeremy Swinarton]

STR:

1. Open some non-about:blank tabs. Add these tabs to a group.
2. Right click the tab group label and click "Delete group".
3. Open Firefox View. The tabs closed as part of the group should be visible.
4. On the right hand side of the entry for one of the closed tabs, click the "X" (remove the tab from history).

Expected result:

• The tab disappears from Firefox View and related history menus.

Actual result:

• Nothing happens.

Notes:
This error appears in console on click: JavaScript error: resource:///modules/sessionstore/SessionStore.sys.mjs, line 4509: NS_ERROR_ILLEGAL_VALUE: Invalid closedId: not found in the closed tabs of any window

Comment 1

[Jeremy Swinarton]

Attachment: Bug 1950123: Allow forgetting history for closed tabs from closed groups r?dao,dwalker

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41c9914e67c0
Allow forgetting history for closed tabs from closed groups r=dao,sessionstore-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/41c9914e67c0

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/41c9914e67c0

Comment 5

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 137.0a1 (2025-02-24) on macOS 14.
The issue is verified fixed with Firefox 138.0a1 (20250304213504) and Firefox 137.0b1 (20250303103151) on macOS 14, Windows 10 and Ubuntu 22.