1950198 - Correct styling details for profile editor

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Cieara Meador [:cmkm] ⛔️ (away through EOY)]

Attachment: Screenshot of Figma design with styling details

Figma

• things need to be more spaced out in general
• 24px padding between sections
• 50px horizontal between icon and text

Theme chip updates:

• active border is too thin, should be 2px
• system chip looks like dark chip (need SVG exported)
• border: #BFBFC9

Avatar updates:

• icons should be bigger, 20px
• active border is too thin, should be 2px

Misha, would you mind attaching the SVG for the System theme chip background to this bug?

Comment 1

[misha [:mbruk]]

Attachment: system_chip_color.svg

thanks for creating these bugs! system chip image attached

Comment 2

[Teddy Bersentes]

Attachment: Bug 1950198 - Correct styling details for profile editor. r=#profiles-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d49b23e12f5c
Correct styling details for profile editor. r=profiles-reviewers,mossop

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d49b23e12f5c

Comment 5

[Teddy Bersentes]

Attachment: Bug 1950198 - Fix to add back focus outline to theme chips for profile group items. r=#profiles-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bf33a9486fb
Fix to add back focus outline to theme chips for profile group items. r=profiles-reviewers,desktop-theme-reviewers,cmkm

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5bf33a9486fb

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)