1950247 - 'Theme' and 'Avatar' should be level 2 headings

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Natalie Stroud [:nstroud]]

Attachment: about:newprofile open with the accessibility properties of 'Theme' visible in DevTools on the right

Prerequisites:

Found on Nightly 137.0a1 (2025-02-24) (64-bit)
Make sure browser.profiles.enabled is set to true
Turn on NVDA

STR:

1. Turn on NVDA
2. Open about:newprofile in Nightly
3. Move NVDA focus to the 'Theme' and 'Avatar' headings and observe NVDA output

NOTE: This can also be checked in DevTools. Highlight 'Theme' or 'Avatar' and right click. When the context menu appears on screen, select 'Inspect Accessibility Properties'. Upon doing this, observe the lack of headings.

Expected / Actual:

The accessibility annotations in Figma have 'Theme' and 'Avatar' listed as <h2>. At this moment, neither one is marked up as a heading.

Comment 1

[Finn Terdal (he/they)]

Attachment: Bug 1950247 - Make theme header level 2 on new/edit profile pages r?jhirsch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/190439863b62
https://hg.mozilla.org/integration/autoland/rev/174c8d22d376
Make theme header level 2 on new/edit profile pages r=jhirsch,profiles-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/174c8d22d376