Closed Bug 1950255 Opened 23 days ago Closed 1 day ago

[wpt-sync] Sync PR 50920 - layout: Remove special height logic of replaced element with auto width

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50920 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50920
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

layout: Remove special height logic of replaced element with auto width

When computing the intrinsic block size of a replaced element with a computed preferred inline size of auto, instead of transferring the final inline size through the aspect ratio, we were only transferring the min and max constraints.

We did this to match other browsers, but Ian Kilpatrick agreed that this is a bug and plans to change Blink.

CSSWG issue: https://github.com/w3c/csswg-drafts/issues/11236

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#35275

PR 50920 applied with additional changes from upstream: 240b357348202856b077417a3ebf944301776a89
Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 6 subtests

Status Summary

Firefox

OK : 4
PASS: 130
FAIL: 135

Chrome

OK : 4
PASS: 196
FAIL: 69

Safari

OK : 4
PASS: 183
FAIL: 82

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-sizing/aspect-ratio/replaced-element-043.html [wpt.fyi]
    • canvas 13: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 14: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 15: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 16: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 17: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 18: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 19: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 20: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 21: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 22: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 23: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 24: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 26: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 27: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 28: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 29: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 30: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 32: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 33: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 34: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 35: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 36: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 37: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 38: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 39: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 40: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 41: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 42: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 43: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 44: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 45: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 46: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 47: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 48: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 49: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 50: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 51: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 52: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 53: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 54: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 55: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 56: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 57: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 58: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 59: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 60: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 61: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 62: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 63: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 64: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 65: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 66: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 67: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 68: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 69: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 70: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 71: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 72: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 74: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 75: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 76: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 77: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 78: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 81: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 82: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 83: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 84: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 88: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 89: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 90: FAIL (Chrome: PASS, Safari: FAIL)
    • canvas 95: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 96: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 102: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 115: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 116: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 121: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 122: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 123: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 124: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 127: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 128: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 129: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 130: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 131: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 132: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 133: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 134: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 135: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 136: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 137: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 138: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 139: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 140: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 141: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 142: FAIL (Chrome: FAIL, Safari: PASS)
    • canvas 143: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 144: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 152: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 153: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 154: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 155: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 156: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 158: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 159: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 160: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 161: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 162: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 164: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 165: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 166: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 167: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 168: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 170: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 171: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 172: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 173: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 174: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 176: FAIL (Chrome: PASS, Safari: PASS)
    • canvas 177: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 178: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 179: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 180: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-sizing/aspect-ratio/replaced-element-044.html [wpt.fyi]
    • canvas 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • canvas 4: FAIL (Chrome: PASS, Safari: PASS)
  • /css/css-sizing/keyword-sizes-on-replaced-element.html [wpt.fyi]
    • .test 52: FAIL (Chrome: PASS, Safari: FAIL)
    • .test 53: FAIL (Chrome: PASS, Safari: FAIL)
    • .test 54: FAIL (Chrome: PASS, Safari: FAIL)
    • .test 55: FAIL (Chrome: PASS, Safari: PASS)
    • .test 56: FAIL (Chrome: PASS, Safari: PASS)
    • .test 57: FAIL (Chrome: PASS, Safari: PASS)
    • .test 71: FAIL (Chrome: FAIL, Safari: FAIL)
    • .test 72: FAIL (Chrome: PASS, Safari: FAIL)
    • .test 74: FAIL (Chrome: PASS, Safari: FAIL)
    • .test 75: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-intrinsic-width-height.html [wpt.fyi]
    • both width/height attributes and style keeping aspect-ratio: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51e3f00d9181 [wpt PR 50920] - layout: Remove special height logic of replaced element with auto width, a=testonly https://hg.mozilla.org/integration/autoland/rev/ed533ab3f8ef [wpt PR 50920] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/51e3f00d9181
https://hg.mozilla.org/mozilla-central/rev/ed533ab3f8ef

Status: NEW → RESOLVED
Closed: 1 day ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.