Closed Bug 1950338 Opened 1 year ago Closed 11 months ago

Rename `invoketarget` to `commandfor`, `invokeaction` to `command`, `InvokerEvent` to `CommandEvent`.

Categories

(Core :: DOM: Core & HTML, task)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox141 --- fixed

People

(Reporter: keithamus, Assigned: keithamus)

References

(Blocks 1 open bug)

Details

Attachments

(8 files, 4 obsolete files)

Bug 1950338 - Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 2: Move invokers meta ini to correct directory r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 5: Remove InvokeEvent, migrate .invoker to CommandEvent .source r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 6: Rename invoker functions to command functions r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 7: Move command&commandfor logic to HTMLButtonElement r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
Bug 1950338 - Part 8: Rename invoketarget->commandfor, invokeaction->command r?#dom-core
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Thanks for filing the issue Keith.

For DevTools, this will impact https://searchfox.org/mozilla-release/rev/201ece97e589a880d0b3f000affc9bf459e90cee/devtools/client/shared/node-attribute-parser.js#162

["invoketarget", { WILDCARD: { namespaceURI: HTML_NS, type: TYPE_IDREF } }],

and https://searchfox.org/mozilla-release/rev/201ece97e589a880d0b3f000affc9bf459e90cee/devtools/server/actors/utils/event-breakpoints.js#144-149

// The condition should be removed when "dom.element.invokers.enabled" is removed
generalEvent(
  "control",
  "invoke",
  global => global && "InvokeEvent" in global
),

(and their related tests)

Summary: Rename `invoketarget` to `commandfor`, `invokeaction` to `command`. → Rename `invoketarget` to `commandfor`, `invokeaction` to `command`, `InvokerEvent` to `CommandEvent`.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED

Renames:

  • IsValidInvokeAction->IsValidCommandAction
  • HandleInvokeInternal->HandleCommandInternal
  • InvokeAction->CommandAction
Attachment #9492712 - Attachment is obsolete: true
Attachment #9492713 - Attachment is obsolete: true
Attachment #9492714 - Attachment is obsolete: true
Attachment #9492715 - Attachment is obsolete: true
Pushed by mozilla@keithcirkel.co.uk: https://github.com/mozilla-firefox/firefox/commit/056df9ff862c https://hg.mozilla.org/integration/autoland/rev/e281b38a22ca Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/7df69f31bd60 https://hg.mozilla.org/integration/autoland/rev/2725f4f2c184 Part 2: Move invokers meta ini to correct directory r=dom-core,sefeng https://github.com/mozilla-firefox/firefox/commit/ff0535eda651 https://hg.mozilla.org/integration/autoland/rev/ca2b05029c48 Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r=webidl,emilio https://github.com/mozilla-firefox/firefox/commit/4803396b658a https://hg.mozilla.org/integration/autoland/rev/35a2af1c4b03 Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/87eece2d58be https://hg.mozilla.org/integration/autoland/rev/ed8d6eab9b76 Revert "Bug 1950338 - Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug"

Backed out for causing build bustages in CommandEvent.cpp

Flags: needinfo?(mozilla)
Flags: needinfo?(mozilla)
Pushed by mozilla@keithcirkel.co.uk: https://github.com/mozilla-firefox/firefox/commit/46191e38f9f1 https://hg.mozilla.org/integration/autoland/rev/81fc6b5ca9a9 Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/2f154a5d387c https://hg.mozilla.org/integration/autoland/rev/e30c8afda2a1 Part 2: Move invokers meta ini to correct directory r=dom-core,sefeng https://github.com/mozilla-firefox/firefox/commit/4323011aee60 https://hg.mozilla.org/integration/autoland/rev/9268bb3517ea Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r=webidl,emilio https://github.com/mozilla-firefox/firefox/commit/719b77b8bdc6 https://hg.mozilla.org/integration/autoland/rev/6855fbc931f4 Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a5af2f601031 https://hg.mozilla.org/integration/autoland/rev/04210a85c9ec Revert "Bug 1950338 - Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug" for causing bp-nu bustages in CommandEvent.cpp.

Reverted this because it was causing bp-nu bustages in CommandEvent.cpp.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/dom/events/CommandEvent.cpp(17,23): error: no member named 'dom_element_commandfor_enabled' in namespace 'mozilla::StaticPrefs'
Flags: needinfo?(mozilla)
Flags: needinfo?(mozilla)
Pushed by mozilla@keithcirkel.co.uk: https://github.com/mozilla-firefox/firefox/commit/532bb887b51b https://hg.mozilla.org/integration/autoland/rev/3bcd4b0bdc51 Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/face866adb76 https://hg.mozilla.org/integration/autoland/rev/d8c9b3aeb737 Part 2: Move invokers meta ini to correct directory r=dom-core,sefeng https://github.com/mozilla-firefox/firefox/commit/eb133a45e691 https://hg.mozilla.org/integration/autoland/rev/543f46ada242 Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r=webidl,emilio https://github.com/mozilla-firefox/firefox/commit/a7a025a8433d https://hg.mozilla.org/integration/autoland/rev/5bbd14de09aa Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug https://github.com/mozilla-firefox/firefox/commit/f7d2727969b0 https://hg.mozilla.org/integration/autoland/rev/f0c63735e587 Part 5: Remove InvokeEvent, migrate .invoker to CommandEvent .source r=webidl,devtools-reviewers,nchevobbe,emilio,smaug https://github.com/mozilla-firefox/firefox/commit/76f840a55a4c https://hg.mozilla.org/integration/autoland/rev/95f3568f0511 Part 6: Rename invoker functions to command functions r=dom-core,masayuki https://github.com/mozilla-firefox/firefox/commit/5a9255cd0b48 https://hg.mozilla.org/integration/autoland/rev/a357a4f8a94a Part 7: Move command&commandfor logic to HTMLButtonElement r=smaug https://github.com/mozilla-firefox/firefox/commit/0fe8930d3204 https://hg.mozilla.org/integration/autoland/rev/4af1a8b35f8c Part 8: Rename invoketarget->commandfor, invokeaction->command r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/d33dcda2c660 https://hg.mozilla.org/integration/autoland/rev/04d615785a3e apply code formatting via Lando
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/025ccdad299b https://hg.mozilla.org/integration/autoland/rev/7f5f527dfbd9 Revert "Bug 1950338: apply code formatting via Lando" for causing build bustages @CommandEvent.cpp.

Backed out for causing build bustages @CommandEvent.cpp.

Flags: needinfo?(mozilla)
Flags: needinfo?(mozilla)
Pushed by mozilla@keithcirkel.co.uk: https://github.com/mozilla-firefox/firefox/commit/f2896c86e62f https://hg.mozilla.org/integration/autoland/rev/bf2b15523abb Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/d86aa9d74ba6 https://hg.mozilla.org/integration/autoland/rev/90975547494d Part 2: Move invokers meta ini to correct directory r=dom-core,sefeng https://github.com/mozilla-firefox/firefox/commit/b7f242a9c0c7 https://hg.mozilla.org/integration/autoland/rev/668c9dce117d Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r=webidl,emilio https://github.com/mozilla-firefox/firefox/commit/8b36f24a15f6 https://hg.mozilla.org/integration/autoland/rev/0b0ece5025dd Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug https://github.com/mozilla-firefox/firefox/commit/4b5aa0f41210 https://hg.mozilla.org/integration/autoland/rev/e47577d5654f Part 5: Remove InvokeEvent, migrate .invoker to CommandEvent .source r=webidl,devtools-reviewers,nchevobbe,emilio,smaug https://github.com/mozilla-firefox/firefox/commit/d78e18b0a54c https://hg.mozilla.org/integration/autoland/rev/4c2744e092ba Part 6: Rename invoker functions to command functions r=dom-core,masayuki https://github.com/mozilla-firefox/firefox/commit/99d03f00d691 https://hg.mozilla.org/integration/autoland/rev/7c462cdeeb06 Part 7: Move command&commandfor logic to HTMLButtonElement r=smaug https://github.com/mozilla-firefox/firefox/commit/5d5b9bb121f5 https://hg.mozilla.org/integration/autoland/rev/da6cfc7c1ec0 Part 8: Rename invoketarget->commandfor, invokeaction->command r=webidl,devtools-reviewers,nchevobbe,smaug https://github.com/mozilla-firefox/firefox/commit/c3c6824fd2e3 https://hg.mozilla.org/integration/autoland/rev/0b0b068bbdd6 apply code formatting via Lando
QA Whiteboard: [qa-triage-done-c142/b141]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: