1950464 - Assertion failure: aWaylandBuffer && !aWlBuffer (Wayland compositor detach call after wl_buffer delete?)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

[Parent 84660: Renderer]: D/WidgetWayland [7f40a8b84ca0]: WaylandSurface::UnmapLocked()
[Parent 84660: Renderer]: D/WidgetWayland [7f40a8b84ca0]: WaylandSurface::ClearScaleLocked()
[Parent 84660: Renderer]: D/WidgetWayland [7f40a8b84ca0]: WaylandSurface::ReleaseAllWaylandBuffersLocked(), buffers num 1
[Parent 84660: Renderer]: D/WidgetWayland WaylandBuffer::ReturnBufferAttached() [7f409b9bbb40] WaylandSurface [7f409d704900]
[Parent 84660: Renderer]: D/WidgetWayland WaylandBuffer::DeleteWlBuffer() [7f409b9bbb40] wl_buffer [7f4096972a60]
[Parent 84660: Renderer]: D/WidgetWayland [7f40a518f040]: WaylandSurface::UnmapLocked()
[Parent 84660: Renderer]: D/WidgetWayland [7f40a518f040]: WaylandSurface::ClearScaleLocked()
[Parent 84660: Main Thread]: D/WidgetWayland BufferDetachedCallbackHandler() [7f409d704900] received wl_buffer [7f4096972a60]
[Parent 84660: Renderer]: D/WidgetWayland [7f40a518f040]: WaylandSurface::ReleaseAllWaylandBuffersLocked(), buffers num 1
[Parent 84660: Renderer]: D/WidgetWayland WaylandBuffer::ReturnBufferAttached() [7f4094271300] WaylandSurface [7f4094a08e00]
[Parent 84660: Renderer]: D/WidgetWayland WaylandBuffer::DeleteWlBuffer() [7f4094271300] wl_buffer [7f4096972760]
[Parent 84660: Main Thread]: D/WidgetWayland [7f40a8b84ca0]: WaylandSurface::BufferFreeCallbackHandler() WaylandBuffer [0] wl_buffer [7f4096972a60]
[84660] Assertion failure: aWaylandBuffer && !aWlBuffer (Wayland compositor detach call after wl_buffer delete?), at /raid/src3/widget/gtk/WaylandSurface.cpp:1148

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: full log

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1950464 [Wayland] Use wl_buffer id instead of wl_buffer to match detached buffer r?emilio

It's possible we get wl_buffer detach callback after wl_buffer delete as the events are waiting in thread queues.
In such case we can't match wl_buffer from wl_buffer::detach as it's already cleared from WaylandBuffer class.
In this patch we always use WaylandBuffer to match detached buffers but we use weak pointer as it's not quaranteed to
get wl_buffer::detach event, for instance if wl_surface/wl_buffer are deleted.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67e0e7d2174b
[Wayland] Use wl_buffer id instead of wl_buffer to match detached buffer r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/67e0e7d2174b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.