1950501 - Content analysis agent timeout/deny-url/etc should always show response

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[David Parks [:handyman]]

When timing out, we issue the default response, which may be to block. The response for items on the deny-url list is always to block. If browser.contentanalysis.show_blocked_result is false then these things will not show a blocked dialog, which means there is no indication of the response, which is wrong. We should always show a dialog in these cases, regardless of the pref value. We can add a boolean to indicate isAgentResponse to the response class, set it for agent responses here, relay that value to _showCAResult here, and add it to the conditional here.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1950501: Ignore browser.contentanalysis.show_blocked_dialog for non-agent messages r=#dlp-reviewers!

Messages not from an agent can't have been shown by an agent, so ignore the pref for them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d16cff0d256f
Ignore browser.contentanalysis.show_blocked_dialog for non-agent messages r=dlp-reviewers,gstoll

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d16cff0d256f