1950508 - Ship Error.captureStackTrace

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

We'll ship this while resolving standardization in parallel

https://github.com/mgaudet/proposal-error-capturestacktrace/blob/main/README.md

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1950508 - Ship Error.captureStackTrace r?dminor!,mccr8!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fdd7a5d986d
Ship Error.captureStackTrace r=dminor,mccr8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5fdd7a5d986d

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Fixes web compat problem
[Affects Firefox for Android]: yes
[Suggested wording]: "Shipped an implementation of Error.captureStackTrace to avoid incompatibility with other browsers. We're also pushing on standardization of this non-standard feature"
[Links (documentation, blog post, etc)]: github.com/tc39/proposal-error-capturestacktrace

Comment 5

[Mayank Bansal]

This lead to an improvement of 4KB on Base content JS opt fission on Windows. No idea why, but i did 5 retriggers and got consistent results.

Comment 6

[Dianna Smith [:diannaS]]

Added to the 138 nightly release notes and on track to be in the final release notes.

Comment 7

[Florin Bilt]

(In reply to Cristian Tuns from comment #3)

https://hg.mozilla.org/mozilla-central/rev/5fdd7a5d986d

Perfherder has detected a awsy performance change from push 5fdd7a5d986dbf8742e762f09d8ae7475aea0455.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.27%	Base Content JS	macosx1470-64-shippable	fission	1,539,680.00 -> 1,535,584.00
0.27%	Base Content JS	windows11-64-24h2-shippable	fission	1,540,640.00 -> 1,536,544.00
0.26%	Base Content JS	windows11-64-24h2-shippable	fission	1,540,946.00 -> 1,536,885.33

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44202

For more information on performance sheriffing please see our FAQ.

Comment 8

[Hamish Willee]

FF138 MDN docs work can be tracked in https://github.com/mdn/content/issues/38879

Not sure if the proposal above counts as a spec from the perspective of the compatibility data team. I've added a PR against the repo to check. If so, there might be some follow on work to tidy the docs.