1950564 - QM: Improve shutdown handling when incremental origin initialization is enabled

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

When incremental origin initialization is enabled, shutdown handling in quota manager needs improvements to ensure a clean and reliable shutdown process. Currently, there may be cases where shutdown occurs while incremental origin initialization is still in progress, potentially leading to inconsistent states.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Ensure shutdown waits for initialization of all temporary origins to finish; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a new testing only notification for origin initialization; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a test for starting shutdown during all temporary origins initialization; r=#dom-storage

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a shutdown check to QuotaManager::EnsureTemporaryGroupIsInitializedInternal; r=#dom-storage

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add support for pausing QM IO thread after finishing group initialization; r=#dom-storage

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a new testing only notification for group initialization; r=#dom-storage

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a disabled secondary test for starting shutdown during all temporary origins initialization; r=#dom-storage

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1950564 - QM: Add a shutdown check to QuotaManager::InitializeAllTemporaryOrigins; r=#dom-storage

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10870b20f6c6
QM: Add a new testing only notification for origin initialization; r=dom-storage-reviewers,jstutte

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d047ac2a08
QM: Add a test for starting shutdown during all temporary origins initialization; r=dom-storage-reviewers,jstutte

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/10870b20f6c6

Comment 12

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_shutdownDuringAllTemporaryOriginsInitialization.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | dom/quota/test/xpcshell/test_shutdownDuringAllTemporaryOriginsInitialization.js | Test timed out

Comment 13

[Jan Varga [:janv]]

The patch has been updated, will be re-landing soon.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34c37186873b
QM: Add a test for starting shutdown during all temporary origins initialization; r=dom-storage-reviewers,jstutte

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/34c37186873b

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7991f261f7a5
QM: Add a shutdown check to QuotaManager::EnsureTemporaryGroupIsInitializedInternal; r=dom-storage-reviewers,jstutte

Comment 17

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7991f261f7a5

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc5ff5a4798d
QM: Add support for pausing QM IO thread after finishing group initialization; r=dom-storage-reviewers,jstutte

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/080b5b6edc6a
QM: Add a new testing only notification for group initialization; r=dom-storage-reviewers,jstutte

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fc5ff5a4798d
https://hg.mozilla.org/mozilla-central/rev/080b5b6edc6a

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d916e08a6db
QM: Add a disabled secondary test for starting shutdown during all temporary origins initialization; r=dom-storage-reviewers,jstutte

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fafefd2f4979
QM: Add a shutdown check to QuotaManager::InitializeAllTemporaryOrigins; r=dom-storage-reviewers,jstutte

Comment 23

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5d916e08a6db
https://hg.mozilla.org/mozilla-central/rev/fafefd2f4979

Comment 24

[Jens Stutte [:jstutte]]

Will this mitigate some of bug 1588510 or do we still need that one ?

Comment 25

[Jan Varga [:janv]]

(In reply to Jens Stutte [:jstutte] from comment #24)

Will this mitigate some of bug 1588510 or do we still need that one ?

I don't think so.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b54e4165726b
QM: Ensure shutdown waits for initialization of all temporary origins to finish; r=dom-storage-reviewers,jstutte

Comment 27

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b54e4165726b