1950565 - CookieStore must enforce the maximum name/value pair size correctly

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Andrea Marchesini [:baku]]

"The combined lengths of the name and value fields must not be greater than 4096 bytes (the maximum name/value pair size)."

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1950565 - CookieStore must enforce the maximum name/value pair size correctly, r?edgul

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c97bdd81621
CookieStore must enforce the maximum name/value pair size correctly, r=edgul,smaug

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50972 for changes under testing/web-platform/tests

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c97bdd81621

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c97bdd81621

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[edgul]

Comment on attachment 9468569 [details]
Bug 1950565 - CookieStore must enforce the maximum name/value pair size correctly, r?edgul

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Websites that use CookieStore cookies with name+value lengths > 1024 will fail. This could cause login and other state-related issues.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky.
  It seems to be fine in nightly and beta.
  No logic is changed, just changed the acceptance limits of cookies being set.
  Also a test was added
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9468569 [details]
Bug 1950565 - CookieStore must enforce the maximum name/value pair size correctly, r?edgul

Approved for 136.0.1

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/1ff99a99c5fb