1950579 - Keyboard navigation in a multi-select with vertical-rl or sideways-rl writing mode is reversed

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

WPT failure: https://wpt.fyi/results/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html?label=experimental&label=master&view=interop&q=label%3Ainterop-2025-writingmodes

Testcase:

data:text/html,<select size=4 style=writing-mode:sideways-rl><option>one<option>two<option>three<option>four<option>five

Click in the <select> and then attempt to use the left- and right-arrow keys to move the highlight back and forth through the options: movement is reversed from the expected direction.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1950579 - Swap behavior of left- and right-arrow keys in list control with vertical-rl writing mode. r=#layout

Comment 2

[Jonathan Kew [:jfkthame]]

The above patch handles this by swapping left/right key codes in nsListControlFrame::HandleEvent, and appears to work as expected in local testing. An alternative approach might be to handle things in HTMLSelectEventListener, but that seems like it might become a somewhat more extensive patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a2b9d6d762c
Swap behavior of left- and right-arrow keys in list control with vertical-rl writing mode. r=layout-reviewers,emilio

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8a2b9d6d762c

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8a2b9d6d762c