1950654 - Selecting a pretty printed location from the source tree selects the non-pretty-printed version

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

When selecting any pretty printed source from the source tree,
the non-pretty-printed version would be selected instead of the pretty printed one.

Probably related to https://phabricator.services.mozilla.com/D236264 which I ran into while looking at bug 1917012.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1950654 - [devtools] Expose a simpler selectSourceFromSourceTree test helper.

This new version doesn't expect a position in the source tree and only a file name.
This should help cover source selection from the Source Tree.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1950654 - [devtools] Allow selecting the pretty printed source when selecting a source from the source tree.

Add a space on math.min.js in order to ensure that the first line of the minimized source doesn't map
to a pretty printed location.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/958da5e1f0c8
[devtools] Expose a simpler selectSourceFromSourceTree test helper. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/3a02c32ac242
[devtools] Allow selecting the pretty printed source when selecting a source from the source tree. r=devtools-reviewers,bomsy

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/958da5e1f0c8
https://hg.mozilla.org/mozilla-central/rev/3a02c32ac242