1950734 - avoid changing process AUMID during MSIX taskbar pinning

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Eric Chen]

Currently PinCurrentAppToTaskbarWin11 swaps the Firefox process AUMID to the shortcut's AUMID before calling the pinning API, this is necessary for pinning to work on Win32. After pinning is complete, we switch the process AUMID back to the original one using GenerateAppUserModelID. This function will always provide the correct original AUMID for Win32 Firefox builds.

However, MSIX Firefox also goes through this code path, even though it's pinning mechanism have major differences from Win32, listed here:

• We can pin MSIX Firefox without doing the AUMID swaps, since the application is already packaged & recognized by the OS
• A MSIX app registers its AUMID with Windows at install time, and its process is expected to always have that AUMID. We shouldn't change it
• The way that GenerateAppUserModelID is written means it will never return the correct value for MSIX Firefox builds, by chance this code works for MSIX even though it calls the function

The easiest fix for all of this is to add if conditions that prevent the AUMID-setting code to run if we're in MSIX. This means the process AUMID will never change yet pinning should still work

Comment 1

[Eric Chen]

Attachment: Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7a895ce1e23
Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel

Comment 3

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures at browser_processAUMID.js

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89afda43893e
Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/89afda43893e