1951093 - Use synced rendering to layers

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Use synced rendering to layers. Right now we use desynced surfaces which eats extra resources and may cause visual artifacts.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

The problem here is that we commit to parent surface (which is requested to promote child changes) in NativeLayerRootWayland::CommitToScreen() only.

So if we ask any layer for frame callback and then do commit in to layer/surface, we don't commit to NativeLayerRootWayland to promote the change and we're missing the frame callback then, as parrent is still pending the commit.

We may manage the frame callbacks globally somehow by NativeLayerRootWayland for all child layers.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1951093 [Wayland] Remove frame callback force commit feature from WaylandSurface as it's not used r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1951093 [Wayland] Rework RequestFrameCallbackLocked r?emilio

• Rename IsEmulatedFrameCallbackPendingLocked() to HasEmulatedFrameCallbackLocked
• Move HasEmulatedFrameCallbackLocked to RequestFrameCallbackLocked as it's used only there
• Remove mBufferAttached check from HasEmulatedFrameCallbackLocked() - it's already at RequestFrameCallbackLocked()

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1951093 [Wayland] Rename WaylandSurface::aLastFrameCallbackTime to mLastFrameCallbackTime r?emilio

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1951093 [Wayland] Call frame callback handlers after RequestFrameCallbackLocked() call r?emilio

• Call frame callback handlers after RequestFrameCallbackLocked(). I allows to perform commit to parent surface from frame callback
  handler of child surface. That's needed for subsurface synced rendering when any wl_subsurface::commit is performed only when parent wl_surface
  is commited too.

• Move mPersistentFrameCallbackHandlers / mOneTimeFrameCallbackHandlers check to RequestFrameCallbackLocked().

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1951093 [Wauland] Use synced rendering to NativeLayerWayland surfaces r?emilio

It ensures all layers are updated once when parent WaylandSurface is committed so we should see less visual artifacts
during resize / scrolling and so on.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11f639848261
[Wayland] Remove frame callback force commit feature from WaylandSurface as it's not used r=emilio
https://hg.mozilla.org/integration/autoland/rev/52d9deed7c7c
[Wayland] Rework RequestFrameCallbackLocked r=emilio
https://hg.mozilla.org/integration/autoland/rev/f52d62a1ed50
[Wayland] Rename WaylandSurface::aLastFrameCallbackTime to mLastFrameCallbackTime r=emilio
https://hg.mozilla.org/integration/autoland/rev/4a17c43ba0b6
[Wayland] Call frame callback handlers after RequestFrameCallbackLocked() call r=emilio
https://hg.mozilla.org/integration/autoland/rev/46fc6ddc0690
[Wauland] Use synced rendering to NativeLayerWayland surfaces r=emilio

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/11f639848261
https://hg.mozilla.org/mozilla-central/rev/52d9deed7c7c
https://hg.mozilla.org/mozilla-central/rev/f52d62a1ed50
https://hg.mozilla.org/mozilla-central/rev/4a17c43ba0b6
https://hg.mozilla.org/mozilla-central/rev/46fc6ddc0690