Closed Bug 1951303 Opened 8 months ago Closed 6 months ago

Use {} and [] instead of new Object() and new Array() in cZ

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

At the moment when creating new Objects and Arrays ChatZilla uses new Object() and new Array(), we should use {} and [] instead.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9469335 - Flags: review?(frgrahl)
Attachment #9469335 - Flags: approval-comm-release?
Whiteboard: SM2.53.21

Comment on attachment 9469335 [details] [diff] [review]
1951303-irc-array-object-25321.patch

LGTM r/a+

Attachment #9469335 - Flags: review?(frgrahl)
Attachment #9469335 - Flags: review+
Attachment #9469335 - Flags: approval-comm-release?
Attachment #9469335 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/534139312f6d
Use {} and [] instead of new Object() and new Array() in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/79ccaf385e876abcb7901345eb92e1fc9da51e0f
Use {} and [] instead of new Object() and new Array() in cZ. r=frg a=frg

Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: