1951362 - Text-Fragments: Consider prefix context terms correctly for range-based text directive

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jan Jaeschke [:jjaschke]]

When creating a text fragment that spans over block boundaries, range-based text directives need to be used (prefix-,start,end,-suffix). Currently, logic for adding the correct prefix is broken, which leads to the first occurrence of start being used. This behavior can be seen in bug 1948506.

At first, this was resolved as patch 2 in bug 1948211. However, part 1 of that patch set needs more work, therefore I'm moving this into its own bug that can be landed first.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1951362 - Text Fragments: Correctly consider prefixes for range-based matching. r=#dom-core!

For range-based matching, the previous matches were determined incorrectly:
The start match must be matched until the end of the start of the target range,
and the end match must be matched until the end of the end of the target rage.

Before this change, the start of the target range was always considered as a
match to eliminate, therefore producing wrong results.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa91bcae0e42
Text Fragments: Correctly consider prefixes for range-based matching. r=dom-core,farre

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aa91bcae0e42