1951367 - 14.39% rasterflood_gradient (Linux) regression on Thu February 27 2025

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Treeherder Bug Filer]

Perfherder has detected a talos performance regression from push d16cff0d256f48bc57c10d166664b574c9a44afb. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,237.25 -> 1,059.17

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44148

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[Florin Bilt]

regression from push 751dd406e9d909f414c8d4263352f7f90983fa1c *

Comment 2

[Florin Bilt]

Perfherder has detected a talos performance change from push 751dd406e9d909f414c8d4263352f7f90983fa1c.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,237.25 -> 1,059.17
3%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2,258.80 -> 2,327.54

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44148

For more information on performance sheriffing please see our FAQ.

Comment 3

[Greg Tatum [:gregtatum]]

profile_rasterflood_gradient

Comment 4

[Greg Tatum [:gregtatum]]

I don't see any translations code running here: https://share.firefox.dev/4i0Eve5

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859081

Comment 6

[Greg Tatum [:gregtatum]]

Reverting changes

• Treeherder with my patch
• Treeherder reverted my patches
• Perf compare

Changes behavior with lang tags

• Treeherder with lang tags in html
• perf compare

Add isInAutomation logging

• treeherder
• perf compare

Add translations logging

• treeherder
• perfcompare

Comment 7

[Greg Tatum [:gregtatum]]

Found a place where we were throwing an error unexpectedly due to a type issue.

• treeherder
• perf-compare

Comment 8

[Greg Tatum [:gregtatum]]

Attachment: Bug 1951367 - Fix a type error for the queryIdentifyLanguage; r?#translations-reviewers!

This leads to an error being thrown, and can slightly slow down the
page. The error didn't cause any visible issues for the user.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0a8d600bdc
Fix a type error for the queryIdentifyLanguage; r=translations-reviewers,nordzilla

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c0a8d600bdc

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gregtatum, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Greg Tatum [:gregtatum]]

Attachment: Bug 1951367 - Fix a type error for the queryIdentifyLanguage;

This leads to an error being thrown, and can slightly slow down the
page. The error didn't cause any visible issues for the user.

Original Revision: https://phabricator.services.mozilla.com/D240505

Comment 13

[Greg Tatum [:gregtatum]]

I changed it to wontfix for 137 rather than uplift, as this only affects CI, and has no user impact.