1951374 - 2.79% damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Treeherder Bug Filer]

Perfherder has detected a devtools performance regression from push c894c73bf604ab4b746607fc8affba317ee6e0bd. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	damp browser-toolbox.styleeditor-ready.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	275.57 -> 283.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44092

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1946523

Comment 2

[Emilio Cobos Álvarez [:emilio]]

• How sure are we about the regressor? Seems somewhat unlikely at a glance.
• Nick any chance you can triage this for severity?

Comment 3

[Florin Bilt]

The graph strongly indicates that this is the culprit.
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=autoland,85770,1,12&timerange=2592000&zoom=1739765071096,1740060684029,258.5003585213315,302.458312965408

Comment 4

[Nick]

emilio yes looking into this now

Comment 5

[Nick]

Attachment: Bug 1951374 - damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025 r=dao!

conditionally loading genai sys file for better performance.

Comment 6

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mconley, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ngrato, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:mak, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Nick]

I'll make sure this get figured out this week, sorry for the delay

Comment 10

[Nick]

@vasish is going to try and get this through for me early next week

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55e483de419
damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025 r=dao,tabbrowser-reviewers,ngrato

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d55e483de419

Comment 13

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 14

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:vbaungally, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Vasish Baungally]

Will uplift.

Comment 16

[Vasish Baungally]

Attachment: Bug 1951374 - damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025 r=dao!

Original Revision: https://phabricator.services.mozilla.com/D241510

Comment 17

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Minor performance impact on windows for browser-toolbox.styleeditor-ready
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Turn off smart tab with browser.tabs.groups.smart.enabled and restart browser. Right click on a tab and "add tab to new group" - there shouldn't be a "Suggest more of my tabs" flow. Turn in back on from about:config and do the flow again. The "Suggest more of my tabs" flow should show.
• Risk associated with taking this patch: Shouldn't be any but we're only conditionally loading the smart tab grouping file until the user opts in.
• Explanation of risk level: The file and event handlers should load properly once the config is enabled.
• String changes made/needed: No
• Is Android affected?: no

Comment 18

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9484694 [details]
Bug 1951374 - damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025 r=dao!

Looks like this patch needs rebasing for Beta uplift.

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5292d47aebb

Comment 21

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/84f78c2792e7

Comment 22

[Cristian Tuns]

Backed out in beta for causing Bug 1964319
Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/84f78c2792e7b1f6cf4e7dcacb5733ad15bd2010

Comment 23

[Vasish Baungally]

Hey Ryan, this doesn't seem to have caused failures in mc but is creating some issues in beta. Can I set this for 139 to wont-fix?