1951481 - [wpt-sync] Sync PR 51060 - Make the condition for "stop decoration propagation" tighter

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51060
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

Make the condition for "stop decoration propagation" tighter

An \<li> marker can generate the following layout tree:
LayoutListItem (children-inline) LI
LayoutInsideListMarker ::marker
LayoutTextFragment (anonymous) "m"
LayoutText #text "a"

If the \<li> has a :first-line style, the marker pseudo element will be
under a parent \<li> with a pseudo style, but the parent's pseudo style
should not apply to the marker. https://crrev.com/1138023 added code to
handle this situation, but it is after a check for stopping, which is
hitting and crashing. This patch makes the condition for "stop
decoration propagation" tighter so that the first-line case falls
into the last resort code.

This is done behind a flag, CssDecoratingBoxFirstLine, for safety.

Fixed: 392927981
Change-Id: Ifccb122ac6aad84e3723f3346cede8971b564586

Reviewed-on: https://chromium-review.googlesource.com/6310509
WPT-Export-Revision: 513e32a3eeafd628e60f720b76d7f75ec35a3844

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=30c5ac760107d82b5bfce26608414d3c22d2c3c3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ee8fdac1ed
[wpt PR 51060] - Make the condition for "stop decoration propagation" tighter, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/54ee8fdac1ed