Closed
Bug 195153
Opened 23 years ago
Closed 23 years ago
Remove bogus 'extern' decls from NS_New* functions.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
108.55 KB,
patch
|
sicking
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Content and layout are full of NS_New* functions and most of them are declared
'extern' for no good reason. None of these functions are extern, they're all
compiled into the same library. This annoys me, so I got rid of them. Patch
coming up.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Attachment #115696 -
Flags: superreview?(dmose)
Attachment #115696 -
Flags: review?(bugmail)
Comment on attachment 115696 [details] [diff] [review]
Remove bogus 'extern' from function declarations
assuming you've just removed the 'extern's and the 'NS_EXPORT's, and that this
still builds. r=sicking
Attachment #115696 -
Flags: review?(bugmail) → review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 115696 [details] [diff] [review]
Remove bogus 'extern' from function declarations
Yay. I've had a patch in my tree for this for a while now, just never got
around to filing a bug. Don't add tabs though! (for example in
nsXULSortService.cpp)
Attachment #115696 -
Flags: superreview?(dmose) → superreview+
|
|
||
Comment 4•23 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•23 years ago
|
||
Sweet! Thanks peterv!
|
||
Comment 6•23 years ago
|
||
<sigh>. This just got backed out when bug 194240 landed.
|
|
||
Comment 7•23 years ago
|
||
Correction, just the nsLayoutModule hunk got backed out; dougt's on it.
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•