1951592 - Initial about:blank with fragment doesn't have events and entries disabled

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Andreas Farre [:farre]]

mozilla::UniquePtr<mozilla::dom::SessionHistoryInfo, mozilla::DefaultDelete<mozilla::dom::SessionHistoryInfo> >::get() const (mfbt/UniquePtr.h:287)
mozilla::UniquePtr<mozilla::dom::SessionHistoryInfo, mozilla::DefaultDelete<mozilla::dom::SessionHistoryInfo> >::operator->() const (mfbt/UniquePtr.h:282)
mozilla::dom::NavigationHistoryEntry::Key() const (dom/navigation/NavigationHistoryEntry.cpp:134)
mozilla::dom::Navigation::UpdateEntriesForSameDocumentNavigation(mozilla::dom::SessionHistoryInfo*, mozilla::dom::NavigationType) (dom/navigation/Navigation.cpp:182)
nsDocShell::HandleSameDocumentNavigation(nsDocShellLoadState*, SameDocumentNavigationState&, bool&) (docshell/base/nsDocShell.cpp:9074)
nsDocShell::InternalLoad(nsDocShellLoadState*, mozilla::Maybe<unsigned int>) (docshell/base/nsDocShell.cpp:9322)
nsDocShell::LoadURI(nsDocShellLoadState*, bool, bool) (docshell/base/nsDocShell.cpp:855)
nsDocShell::LoadURI(nsDocShellLoadState*, bool) (docshell/base/nsDocShell.cpp:686)
mozilla::dom::BrowsingContext::LoadURI(nsDocShellLoadState*, bool) (docshell/base/BrowsingContext.cpp:2009)
mozilla::dom::LocationBase::SetURI(nsIURI*, nsIPrincipal&, mozilla::ErrorResult&, bool) (dom/base/LocationBase.cpp:162)
mozilla::dom::LocationBase::SetHrefWithBase(nsTSubstring<char> const&, nsIURI*, nsIPrincipal&, bool, mozilla::ErrorResult&) (dom/base/LocationBase.cpp:251)
mozilla::dom::LocationBase::DoSetHref(nsTSubstring<char> const&, nsIPrincipal&, bool, mozilla::ErrorResult&) (dom/base/LocationBase.cpp:202)
mozilla::dom::LocationBase::SetHref(nsTSubstring<char> const&, nsIPrincipal&, mozilla::ErrorResult&) (dom/base/LocationBase.cpp:194)
mozilla::dom::Location_Binding::set_href(JSContext*, JS::Handle<JSObject*>, void*, JSJitSetterCallArgs) (dom/bindings/LocationBinding.cpp:125)
mozilla::dom::binding_detail::GenericSetter<mozilla::dom::binding_detail::CrossOriginThisPolicy>(JSContext*, unsigned int, JS::Value*) (dom/bindings/BindingUtils.cpp:3250)
...

/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc.html

Comment 1

[Andreas Farre [:farre]]

This particular crash in NavigationHistoryEntry::Key() is due to initial about:blank with a fragment not being considered to have entries and events disabled.

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1951592 - Initial about:blank with fragment should have entries disabled. r=avandolder!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d576d0044707
Initial about:blank with fragment should have entries disabled. r=avandolder

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d576d0044707