1951605 - Make InspectorUtils.getRuleBodyText handle CSSNestedDeclarations

Status: ASSIGNED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, we can't retrieve a CSSNestedDeclarations authored text as we explicitly bail out in https://searchfox.org/mozilla-release/rev/e38acda63624c7058df4c5adb1f61f9787ed1968/devtools/server/actors/style-rule.js#806,821-823

async getAuthoredCssText(skipCache = false) {
...
    if (this.ruleClassName == "CSSNestedDeclarations") {
      throw new Error("getRuleText doesn't deal well with bare declarations");
    }

with Bug 1950551, we'll get the proper line and column for the rule, so we should try to make InspectorUtils.getRuleBodyText work for CSSNestedDeclarations

This might also help with Bug 1946439 where we need to fix InspectorUtils.replaceBlockRuleBodyTextInStylesheet, which is doing similar work than InspectorUtils.getRuleBodyText

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Servo_GetRuleBodyText needs to be modified: https://searchfox.org/mozilla-release/rev/350db22c9b6a687565189a42fc49dc58c05566b6/servo/ports/geckolib/glue.rs#9407-9446

Emilio, I was thinking of passing a new is_nested_declarations bool parameter to the function, and then parse declarations until we find a selector or the parent rule closing curly bracket (or end of the file).
Do you think I could use https://docs.rs/cssparser/latest/cssparser/fn.parse_one_declaration.html until it returns a parse error? Or is there something else that I could do to achieve what I want?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

You probably want something like https://searchfox.org/mozilla-release/rev/350db22c9b6a687565189a42fc49dc58c05566b6/servo/components/style/stylesheets/mod.rs#616

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1951605 - [devtools] Support CSSNestedDeclarations in InspectorUtils.getRuleBodyText. r=emilio.