1951651 - The contextual opt-in message is displayed for a moment when re-focusing the addressbar after the message previously dismissed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: opt-in message is re-displayed for a moment after is dismissed.mp4

[Affected versions]:

• Firefox Beta 137.0b7 (Build ID: 20250303103151)
• Nightly 138.0a1 (Build ID: 20250219215346)

[Affected Platforms]:

• Windows 10 x64
• MacOS 14.7.1
• Linux Mint 20.1

[Prerequisites]:

• Have a Firefox Beta 137 en-US build installed/extracted.
• Have the following prefs set:
• browser.search.region = US
• browser.urlbar.quicksuggest.contextualOptIn = true

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Click in the addressbar.
3. Click the "Not now" button.
4. Click again in the addressbar.
5. Observe the behavior.

[Expected result]:

• The opt-in message is no longer displayed.

[Actual result]:

• The opt-in message is displayed for a moment, then disappears.

[Notes]:

• The issue is NOT reproducible on Firefox Release 136, it seems that it was introduced with the latest updates.
• The issue is reproducible in both cases if the "Allow Suggestions" or "Not Now" button is clicked.
• Attached is a screen recording of the issue.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1951651: Fix the call to #shouldDisplayContextualOptIn

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033e4187513c
Fix the call to #shouldDisplayContextualOptIn r=dao

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/033e4187513c

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9469854 [details]
Bug 1951651: Fix the call to #shouldDisplayContextualOptIn

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: After user approves/dismisses the contextual opt-in result, the result still remain for a short time in the urlbar when next query.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1951649
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change affects only the contextual opt-in result.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 138.0a1 (Build ID: 20250306213030) on Windows 11 x64, macOS 14.7.1 and Linux Mint 20.1 x64.

• The issue is no longer reproducible, the opt-in message is no longer displayed if it's dismissed and the adressbar is re-focused.

I will verify the issue on Beta 137 as soon as it's uplifted.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/37222381a029

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on the latest Beta 137.0b4 (Build ID: 20250310091737) on Windows 10 x64, macOS 14.7.1 and Linux Mint 20.1.

• The issue is no longer reproducible, the opt-in message is no longer displayed if it's dismissed and the adressbar is re-focused.