1951734 - Reword JSMSG_TEMPORAL_DURATION_INVALID_NON_FINITE error message.

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

The JSMSG_TEMPORAL_DURATION_INVALID_NON_FINITE is used to report a non-finite duration part to the developer. The current wording is "duration value "{0}" is {1}", I think it would be more helpful to say "duration value "{0}" is non-finite: {1}".

This is a good first bug, the main complexity will be getting the SpiderMonkey / Firefox build working.

1. Make sure you can build SpiderMonkey. You can find instructions on building here: https://firefox-source-docs.mozilla.org/js/build.html.
2. Change the error message, and then make sure the build is still working and you can run the tests. You might need to make some changes to the tests if they were expecting the old error message.
3. Now you can commit your changes. Your commit message should look like: Bug X - Reword JSMSG_TEMPORAL_DURATION_INVALID_NON_FINITE error message; r=dminor!, where X is the number for this bug.
4. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[tannal2409]

Attachment: Bug 1951734 - Reword JSMSG_TEMPORAL_DURATION_INVALID_NON_FINITE error message. r=dminor!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b36a3d9b771
Reword JSMSG_TEMPORAL_DURATION_INVALID_NON_FINITE error message. r=dminor

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0b36a3d9b771