1951737 - Reword JSMSG_TEMPORAL_DURATION_INVALID_NORMALIZED_TIME error message.

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

The JSMSG_TEMPORAL_DURATION_INVALID_NORMALIZED_TIME error is used to report a too large time to the developer. The current wording is "time duration values must be lower than 253 seconds", I think it would be better to say "time duration values must be smaller than 253 seconds".

This is a good first bug, the main complexity will be getting the SpiderMonkey / Firefox build working.

1. Make sure you can build SpiderMonkey. You can find instructions on building here: https://firefox-source-docs.mozilla.org/js/build.html.
2. Change the error message, and then make sure the build is still working and you can run the tests. You might need to make some changes to the tests if they were expecting the old error message.
3. Now you can commit your changes. Your commit message should look like: Bug X - Reword JSMSG_TEMPORAL_DURATION_INVALID_NORMALIZED_TIME error message; r=dminor!, where X is the number for this bug.
4. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[tannal2409]

Attachment: Bug 1951737 - Reword JSMSG_TEMPORAL_DURATION_INVALID_NORMALIZED_TIME error message; r=dminor!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f2719e49b12
Reword JSMSG_TEMPORAL_DURATION_INVALID_NORMALIZED_TIME error message; r=dminor

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0f2719e49b12