1951797 - [css-view-transitions] Behavior of calling `document.startViewTransition` synchronously more than once

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#11292.

[css-view-transitions] Behavior of calling `document.startViewTransition` synchronously more than once

• RESOLVED: When starting a new view transition, have the previous active transition do all its cancelation behaviours before the new transition does any of its capturing.

Discussion.

Comment 1

[Boris Chiou [:boris]]

This is a spec change recently. In setup the view transition, the step 2 is Flush the update callback queue now.

This mean we may have to flush the update callback before capturing the old state in Setup().

The testcase is in the spec issue, or Chromium may add one in https://issues.chromium.org/issues/379422729.

Comment 2

[Boris Chiou [:boris]]

I notice the test case in Bug 1952366 crashes when calling getKeyframes(). The test will be added together with this spec update from Chromium side, so I'm trying to figure out why we got crashes and perhaps fix this bug together.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1951797 - Fix the typo that we should set height value into the proper declartion.

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1951797 - Flush the pending update callbacks before capturing the old state.

Now we flush the update callback queue before scheduling the new
callback in Setup() to make sure the previous update callbacks get
invoked before we do capturing.

The test case is
css/css-view-transitions/start-view-transtion-skips-active.html, which
is not merged into Gecko yet, so I only can verify this locally with
this test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20d6fcfc4372
Fix the typo that we should set height value into the proper declartion. r=view-transitions-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/97f0dc799a56
Flush the pending update callbacks before capturing the old state. r=view-transitions-reviewers,emilio

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing wpt failures on start-view-transtion-skips-active.html

Backout link

Push with failures

Failure log

Comment 7

[Boris Chiou [:boris]]

Looks like start-view-transtion-skips-active.html also got merged in the same day. :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f747d43d12ee
Fix the typo that we should set height value into the proper declartion. r=view-transitions-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/2dbcd0f2826c
Flush the pending update callbacks before capturing the old state. r=view-transitions-reviewers,emilio

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f747d43d12ee
https://hg.mozilla.org/mozilla-central/rev/2dbcd0f2826c