1951861 - Tweak `grid-max-sizing-flex-006.html` and add a web-platform test

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

This is a preparation towards fixing bug 1481876.

Tweak grid-max-sizing-flex-006.html and add a web-platform tests for 12.7. Expand Flexible Tracks. See the commit message in the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1951861 Part 1 - Adjust flexible track sizes in grid-max-sizing-flex-006.html to make the row sizes align with a quarter of a pixel.

This patch maintains the intent of the sub-test that validates the fractional
fr unit. However, the flex factor sum, which is used to be less than one, now
becomes greater than one. Therefore, I have distilled this sub-test into a
web-platform test in the next part to exercise the code path and the behavior
described in spec 12.7.1.2 [1].

[1] https://drafts.csswg.org/css-grid-2/#algo-find-fr-size

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1951861 Part 2 - Add a web-platform test for expanding flexible tracks with a fractional size.

Both Chrome and Safari pass the test, while Firefox fails it currently. Firefox
is expected to pass it after Bug 1481876 is fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab98d96d49e
Part 1 - Adjust flexible track sizes in grid-max-sizing-flex-006.html to make the row sizes align with a quarter of a pixel. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ef9f9062d724
Part 2 - Add a web-platform test for expanding flexible tracks with a fractional size. r=dholbert,layout-grid-reviewers

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51180 for changes under testing/web-platform/tests

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1ab98d96d49e
https://hg.mozilla.org/mozilla-central/rev/ef9f9062d724

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot