1952022 - Reword JSMSG_TEMPORAL_PARSER_BRACKET_BEFORE_ANNOTATION error message.

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

The JSMSG_TEMPORAL_PARSER_BRACKET_BEFORE_ANNOTATION has a typo, the current wording is "can't parse {0}: missing ']' before annotation", but it should say "can't parse {0}: missing '[' before annotation", the character being checked can be seen here.

This is a good first bug, the main complexity will be getting the SpiderMonkey / Firefox build working.

1. Make sure you can build SpiderMonkey. You can find instructions on building here: https://firefox-source-docs.mozilla.org/js/build.html.
2. Change the error message, and then make sure the build is still working and you can run the tests. You might need to make some changes to the tests if they were expecting the old error message.
3. Now you can commit your changes. Your commit message should look like: Bug X - Reword JSMSG_TEMPORAL_PARSER_BRACKET_BEFORE_ANNOTATION error message; r=dminor!, where X is the number for this bug.
4. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[Joshua O'Brien]

Attachment: Bug 1952022 - Reword JSMSG_TEMPORAL_PARSER_BRACKET_BEFORE_ANNOTATION error message; r=dminor!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24a58a755c5f
Reword JSMSG_TEMPORAL_PARSER_BRACKET_BEFORE_ANNOTATION error message; r=dminor

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/24a58a755c5f