1952396 - Debug-only logging tab-crash in getUserMedia playback with MOZ_LOG=MediaManager:5

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR:

1. In about:logging, set Log Modules to "MediaManager:5"
2. Open https://jan-ivar.github.io/dummy/gum_video.html

Expected result:

• camera self view video playing

Actual result:

[50028] Assertion failure: mIsValid (Invalid checked integer (division by zero or integer overflow)), at /Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/include/mozilla/CheckedInt.h:562
#01: mozilla::CheckedInt<long long>::value() const[/Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x13e0474]
#02: mozilla::media::TimeUnit::ToCommonUnit(long long) const[/Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x84ece58]
#03: mozilla::media::TimeUnit::ToMicroseconds() const[/Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x84ed010]
#04: mozilla::MediaEngineRemoteVideoSource::DeliverFrame(unsigned char*, mozilla::camera::VideoFrameProperties const&)[/Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x8f97024]
#05: mozilla::camera::CamerasChild::RecvDeliverFrame(int const&, mozilla::ipc::Shmem&&, mozilla::camera::VideoFrameProperties const&)[/Users/jan-ivar/moz/mozilla-unified/obj-aarch64-apple-darwin23.6.0-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x8c94eac]

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1952396 - Remove processingDuration from local camera videoframes. r?pehrsons

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1908245

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab6f21d57db1
Remove processingDuration from local camera videoframes. r=webrtc-reviewers,ng,pehrsons

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ab6f21d57db1

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jib, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Monica Chiorean]

I am not able to reproduce the issue on Win11/Ubuntu 24.04 using Firefox builds 137.0 and 138.0 and steps from description, for me the camera always opens without errors.
Jan-Ivar, is there something that I am missing? I need to reproduce the issue in order to confirm the fix. Thank you.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

It only happens in DEBUG builds.

Comment 8

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using Firefox build 138.0a1 debug build, tab crashed.
Verified that on Win11x64 using Firefox debug build 140.0b5 the camera opens.