1952701 - CPManager extension stops working after upgrading to Firefox 136.0

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[esterTion]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

After upgrading from 135 to 136, CPManager ( [e-mail] , link http://g-fox.cn/chinaedition/addons/cpmanager/cpmanager-5.114-fx.xpi from https://addons.firefox.com.cn/chinaedition/addons/updates.json ) stops working.
This extension includes useful features such as listed recently closed tabs, and qrcode for current tab.
Also does not work on Firefox Nightly 138.0a1.

I'm unable to file this bug under Mozilla China, please help correct this bug into appropriate category.

Comment 1

[Gregory Pappas [:gregp]]

this function in undoCloseTab.js iterates over the array CREATED_MENU_IDS and calls browser.menus.remove on each element. Probably, the function is throwing because one of the menus does not exist. This behavior was introduced in bug 1688743

async function rebuildBrowserActionContextForReal(sessionsToRestore) {
  if (rebuildBrowserActionContextTimer) {
    rebuildBrowserActionContextTimer = undefined;
  }

  await Promise.all(CREATED_MENU_IDS.map(menuId => {
    return browser.menus.remove(menuId);
  }));
  CREATED_MENU_IDS.length = 0;
  if (!sessionsToRestore.length) {
    return;
  }

  let mostRecentSessions = sessionsToRestore.slice(0,
    browser.menus.ACTION_MENU_TOP_LEVEL_LIMIT - 1);
  for (let session of mostRecentSessions) {
    CREATED_MENU_IDS.push(browser.menus.create({
      contexts: ["browser_action"],
      icons: {
        "16": (session.tab.favIconUrl || "icons/defaultFavicon.svg"),
      },
      onclick: () => browser.sessions.restore(session.tab.sessionId),
      title: session.tab.title,
    }));
  }

  CREATED_MENU_IDS.push(browser.menus.create({
    contexts: ["browser_action"],
    onclick: () => {
      return Promise.all(sessionsToRestore.map(session => {
        return browser.sessions.restore(session.tab.sessionId);
      }));
    },
    title: browser.i18n.getMessage("restoreAllTabs"),
  }));
}

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1688743

:kernp25, since you are the author of the regressor, bug 1688743, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[esterTion]

looks like undoCloseTab.js is working just fine, if i remove mozillaAddons from permissions and remove experiment_apis, the browserAction button is functioning.
i would assume there is something changed to internal stuff, as this extension heavily relys on legacy XPC API.

Comment 4

[Gregory Pappas [:gregp]]

ext-chinaPackageManager.js is doing a bunch of ChromeUtils.importing. This method was removed in bug 1881888. This is probably the real cause of the breakage then.

Comment 5

[Rob Wu [:robwu]]

This extension includes useful features such as listed recently closed tabs

This functionality is built-in; you can access it via History > Recently Closed Tabs.
The documentation for that is https://support.mozilla.org/en-US/kb/how-do-i-restore-my-tabs-last-time

Chinese version of the documentation ("如何恢复上次的标签页？"): https://support.mozilla.org/zh-CN/kb/%E6%81%A2%E5%A4%8D%E4%B8%8A%E6%AC%A1%E7%9A%84%E6%A0%87%E7%AD%BE%E9%A1%B5

, and qrcode for current tab.

There are other add-ons with such functionality, such as https://addons.mozilla.org/en-US/firefox/addon/qr-code-generator/

---

The user-visible part of the context menus being broken is caused by bug 1688743.
But the majority of the customizations of the CPManager extension is mostly broken due to the JSM removal (bug 1881888).
JSM functionality is deprecated and its removal was announced before at https://groups.google.com/a/mozilla.org/g/dev-platform/c/HJHAaGKSeGU. We are not going to revert this.

I described the exact extent to which the MozillaOnline add-ons are broken, at https://docs.google.com/document/d/1J1wpk0q7REltTGj1YNJSQlmpxanQbGztgUpNCHye4Bw/edit

Comment 6

[esterTion]

This functionality is built-in; you can access it via History > Recently Closed Tabs.

That was three clicks deep, compared to extensions using one click

I did already found all the replacement extension for features I want.
My install was so old and I always assumed these are default feature from Firefox, and found out it is a repack only extension later when I was installing in a new environment.

Legacy extensions are good to be left behind, hopefully Firefox will become more performant with less old stuff needing support.
(I actually thought legacy extension were already unsupported years ago, no idea these was one in my install all the time)

Comment 7

[Rob Wu [:robwu]]

We have published new versions of the extension that are compatible with the latest Firefox versions.