Closed Bug 1952980 Opened 1 year ago Closed 1 year ago

WGSL: Texture built-ins don't support all overloads or apply automatic type conversion

Categories

(Core :: Graphics: WebGPU, defect)

Product:
Core
Component:
Graphics: WebGPU
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ErichDonGubler, Assigned: jimb)

References

(Blocks 3 open bugs)

Details

WGPU upstream tracking: wgpu#7488

Depends on: 1952126
Summary: WGSL: `Image sample or level-of-detail index's type of … is not an integer scalar` → WGSL: Support all overloads for texture built-ins
Summary: WGSL: Support all overloads for texture built-ins → WGSL: Texture built-ins don't support all overloads
Duplicate of this bug: 1960410
Summary: WGSL: Texture built-ins don't support all overloads → WGSL: Texture built-ins don't support all overloads or apply automatic type conversion

I believe this should be fixed by the following pull requests

  • merged: [naga wgsl-in] Convert textureStore values correctly. #7567
  • merged: [naga wgsl-in] Apply automatic conversions to sampling arguments. #7548
  • awaiting review: [naga wgsl-in] Properly convert arguments to atomic operations. #7573
Assignee: nobody → jimb

:jimb: Atomic operations were split out to bug 1960093, FYI.

Depends on: 1961411
No longer depends on: webgpu-update-wgpu

I believe this is fixed by bug 1962269.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Re-opened, until we're sure that bug 1962269 sticks its landing.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Okay, it landed!

Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.