1953029 - [meta] Add a way to simulate the dynamic toolbar in Responsive Design Mode

Status: REOPENED

(DevTools :: Responsive Design Mode, enhancement, P3)

Description

[Botond Ballo [:botond]]

Similar to bug 1950771, and originally suggested by Emilio in Dublin but I don't think we've filed a bug for it so far: it would be great if Responsive Design Mode had a way of simulating Firefox for Android's "dynamic toolbar" (the address bar that animates offscreen in response to scrolling if the "Scroll to hide toolbar" setting is enabled).

We get a lot of APZ and Layout bugs that are specific to viewport sizing in the presence of the dynamic toolbar (i.e. issues related to whether various viewport-related quantities such as the layout viewport, visual viewport, initial containing block, containing block for fixed descendants, etc. include or exclude the dynamic toolbar height). Being able to reproduce and investigate such bugs in a desktop build using RDM would be a significant productivity improvement for us.

Comment 1

[Botond Ballo [:botond]]

As with bug 1950771, for our purposes we wouldn't need RDM's dynamic toolbar to be a functional toolbar (e.g. to have a URL input field), we're just after its effects on viewport sizing.

Comment 2

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1953029 - Pass WindowGlobalTargetActor to TouchSimulator in RDM r=#devtools-reviewers,mstange

Comment 3

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1953029 - Add dynamic toolbar to frontend of responsive design mode r=mstange,#devtools-reviewers

Comment 4

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1953029 - Dynamic toolbar in RDM reacts to events from touch simulator r=mstange,#devtools-reviewers

Comment 5

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1953029 - Make calls to DynamicToolbarOffsetChanged and DynamicToolbarMaxHeightChanged available for desktop platforms r=botond,mstange

This makes formerly Android-exclusive DynamicToolbarOffsetChanged and DyamicToolbarMaxHeightChanged methods
available for desktop platforms.
Also adds forwards of DynamicToolbarOffsetChanged to compositor and nsBaseWidget.

Comment 6

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1953029 - Add SetVerticalClipping and SetDynamicToolbarMaxHeight methods to InspectorUtils r=mstange,botond

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb7daaa85c3f
Pass WindowGlobalTargetActor to TouchSimulator in RDM r=devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fb7daaa85c3f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c42c26992b9d
Add dynamic toolbar to frontend of responsive design mode r=devtools-reviewers,nchevobbe

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c42c26992b9d

Comment 11

[Alex Jakobi [:ajakobi]]

Converting this into a [meta] bug.

Comment 12

[Phabricator Automation]

Comment on attachment 9486586 [details]
Bug 1953029 - Dynamic toolbar in RDM reacts to events from touch simulator r=mstange,#devtools-reviewers

Revision D248611 was moved to bug 1970616. Setting attachment 9486586 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9486593 [details]
Bug 1953029 - Make calls to DynamicToolbarOffsetChanged and DynamicToolbarMaxHeightChanged available for desktop platforms r=botond,mstange

Revision D248616 was moved to bug 1970617. Setting attachment 9486593 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9486597 [details]
Bug 1953029 - Add SetVerticalClipping and SetDynamicToolbarMaxHeight methods to InspectorUtils r=mstange,botond

Revision D248619 was moved to bug 1970618. Setting attachment 9486597 [details] to obsolete.