1953077 - www.nintendo.com - The slides from the guide are blank

Status: ASSIGNED

(Web Compatibility :: Site Reports, defect, P2)

Description

[Calin Tanase]

Environment:
Operating system: Android 10
Firefox version: Firefox Mobile [phone]

Preconditions:

• Account needed

Steps to reproduce:

1. Go to https://www.nintendo.com/it-it/Notizie/Guida-strategica-di-Super-Mario-Bros-Il-Film-2533905.html
2. Log into your account.
3. Observe the guide.

Expected Behavior:
The slides of the guide are visible.

Actual Behavior:
The slides of the guide are blank.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/149642

Comment 1

[Calin Tanase]

Attachment: image.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: testcase 1 (partially reduced)

Comment 4

[Daniel Holbert [:dholbert]]

I spun off bug 1953879 as a platform bug for this.

We could deploy the following CSS sitepatch to work around this:

.slider .slider__container img {
  flex-shrink: 0;
}

(The issue here has to do with the fact that these images given a specified width:100%, and the site expects them to take on that width, but we shrink them (taking advantage of the default flex-shrink:1) in an attempt to get them all to fit into their flex container. Chrome/WebKit also attempt to shrink the images, but they don't actually have any room to shrink because they immediately run into their resolved automatic minimum width, which they resolve as also being 100%, basically. So one way to match their behavior with an intervention here is to simply disable shrinking for these images, as the above CSS snippet would do.)

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1953077 - add a CSS webcompat intervention for Nintendo's movie guidebook page to un-hide the images; r?denschub

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a36a1396befe
add a CSS webcompat intervention for Nintendo's movie guidebook page to un-hide the images; r=denschub,webcompat-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a36a1396befe

Comment 8

[Jeff Muizelaar [:jrmuizel]]

This doesn't affect most people using nintendo.com