1953080 - Update bundled PipeWire library

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Jan Grulich]

Our bundled copy of PipeWire was introduced more than 2 years ago and it is currently quite outdated. We should update it to the latest available version, which is currently (recently released) PipeWire 1.4.0.

Comment 1

[Jan Grulich]

Attachment: Bug 1953080 - Migrate vendored PipeWire to 'mach vendor' r=pehrsons,ng,mjf

Update bundled copy of PipeWire library to latest stable release.

Comment 2

[Jan Grulich]

Attachment: Bug 1953080 - WebRTC backport: Fix build with Pipewire 1.4 r=pehrsons

Pipewire 1.4 changed some functions from taking void*
to taking the actual type they expect, which makes
some code that built with 1.2 no longer build with 1.4.

For older versions, this is effectively a no-op.

Comment 3

[Jan Grulich]

Attachment: Bug 1953080 - Workaround broken build with PipeWire 1.4 r=pehrsons,mjf

PipeWire 1.4 includes math.h inside an extern "C" block, which breaks
including the header from C++. This is because we end up including
throw_gcc.h from memory/mozalloc, but we won't have _LIBCPP_VERSION
defined. To workaround this issue we just additionally include a header
from the standard C++ library to have _LIBCPP_VERSION defined.

Same issue as fixed here https://phabricator.services.mozilla.com/D11837

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4662f430e6c0
WebRTC backport: Fix build with Pipewire 1.4 r=pehrsons,webrtc-reviewers

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4662f430e6c0

Comment 6

[Jan Grulich]

Attachment: Bug 1953080 - Workaround broken build with PipeWire 1.4 r=pehrsons

PipeWire 1.4 includes math.h inside an extern "C" block, which breaks
including the header from C++. This is because we end up including
throw_gcc.h from memory/mozalloc, but we won't have _LIBCPP_VERSION
defined. Workaround for this issue is not to include <pipewire/conf.h>
from the main <pipewire/pipewire.h> header, as this leads to inclusion
of <spa/json-core.h> where the math.h header is used. We don't currently
need this in Firefox anyway.

Comment 7

[Jan Grulich]

Attachment: Bug 1953080 - Update bundled PipeWire to version 1.4.2 r=pehrsons,ng

Update bundled copy of PipeWire library to latest stable release.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c6a028bd334
Migrate vendored PipeWire to 'mach vendor' r=pehrsons,ng
https://hg.mozilla.org/integration/autoland/rev/343d10152bf8
Update bundled PipeWire to version 1.4.2 r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/281cb8348dfa
Workaround broken build with PipeWire 1.4 r=pehrsons

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5c6a028bd334
https://hg.mozilla.org/mozilla-central/rev/343d10152bf8
https://hg.mozilla.org/mozilla-central/rev/281cb8348dfa

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.