"Open and Show" for OpenPGP-signed message (.eml) does not work
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(thunderbird_esr140 affected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr140 | --- | affected |
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [mailsec-broken-fixwanted])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
corey
:
approval-comm-beta-
|
Details | Review |
|
22.36 KB,
patch
|
Details | Diff | Splinter Review |
Bug 1943021 fixed opening the message. But the "Open and Show" button is still non-functional.
Test case: attachment 9460967 [details].
I'll note, also "Save as" for the .eml strangely gives wrong/different mime boundaries than in the original.
|
Assignee | |
Updated•10 months ago
|
|
||
Updated•2 months ago
|
|
||
Updated•2 months ago
|
|
|
Assignee | |
Comment 1•2 months ago
•
|
||
()
|
||
Updated•2 months ago
|
|
|
||
Comment 2•1 month ago
|
||
|
|
||
Updated•1 month ago
|
|
|
||
Comment 3•1 month ago
|
||
Magnus, are you ok with backporting?
I tried to merge to esr140, see attached patch, and it seems to work in my manual testing.
|
|
Assignee | |
Comment 4•1 month ago
|
||
Now with monthly releases, I'm not sure this would be considered uplift-worthy, though it's in one way fairly contained.
Mostly took it on as the bug made other analysis work more difficult than it should be.
|
|
Assignee | |
Updated•1 month ago
|
|
|
Assignee | |
Comment 5•1 month ago
|
||
|
|
Assignee | |
Updated•1 month ago
|
|
|
Assignee | |
Comment 6•1 month ago
|
||
Comment on attachment 9524992 [details]
Bug 1953098 - Open And Show signed .eml. r=kaie
Uplift Approval Request
- Please state case for uplift consideration and ensure bug severity is set: Broken functionality
- User impact if declined: Non working feature, confusion.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Daily?: Yes
- Has the fix been verified in Beta?: No
- Needs manual test from QA?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's pretty confined to what was broken
- Does the fix cause any migrations to be skipped?: No
- String changes made/needed:
|
||
Comment 7•1 month ago
•
|
||
Comment on attachment 9524992 [details]
Bug 1953098 - Open And Show signed .eml. r=kaie
[Triage Comment]
I don't think this qualifies for uplift unfortunately. Please demonstrate that it is a high-impact issue that qualifies according to these guidelines: https://developer.thunderbird.net/releases/uplifting-fixes
Description
•