1953179 - Unable to select any options from the Manage Tab group panel with the Enter key

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: EnterButtonselect.mp4

Found in

• 138.0a1 (2025-03-11)

Affected versions

• 138.0a1 (2025-03-11)
  137.0b4

Affected platforms

• All

Steps to reproduce

1. Create a Tab group and reach the Manage Tab group panel using keyboard navigation.
2. Select any option using the Enter key.

Expected result

• The Tab group panel options should be selected with the Enter or Space keys.
  Only Escape key should dismiss the panel.

Actual result

• The Enter key will dismiss the panel.

Regression range
Not a Regression

Comment 1

[Eitan Isaacson [:eeejay]]

Space works, but enter doesn't.

Comment 2

[Eitan Isaacson [:eeejay]]

On second thought, I'm going to make this access-s2 because pressing enter on a focused item is such a basic function, even if there is a workaround with space.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=dwalker

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa742bc59c5c
Fix enter key handling on toolbarbuttons in tab group menu. r=dwalker,tabbrowser-reviewers

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fa742bc59c5c

Comment 6

[Cristina Horotan [:chorotan]]

Reopening because of this perma failure

Backed out for causing perma bc failures at browser_tab_groups.js.

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05aa1dfe97f7
Fix enter key handling on toolbarbuttons in tab group menu. r=dwalker,tabbrowser-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/05aa1dfe97f7

Comment 9

[Rares Doghi, Desktop QA]

Hi @Dao, we tested this in our latest Nighty build 139.0a1 (2025-04-13) and the Cancel and Suggest more tabs buttons still do not work with the enter key, the buttons from the Suggest more Tabs Onboarding panel do not work either.

Comment 10

[Dão Gottwald [:dao]]

(In reply to Rares Doghi, Desktop QA from comment #9)

Hi @Dao, we tested this in our latest Nighty build 139.0a1 (2025-04-13) and the Cancel and Suggest more tabs buttons still do not work with the enter key, the buttons from the Suggest more Tabs Onboarding panel do not work either.

Could you please file two separate bugs on these, one for Cancel and Suggest more tabs, and one for the onboarding panel?

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 139.0a1 (2025-04-13). Added bug 1960295 and bug 1960296 for the remaining issues.

Comment 12

[Dão Gottwald [:dao]]

Attachment: Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=#release-managers

Comment 13

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: See https://bugzilla.mozilla.org/show_bug.cgi?id=1953179#c0
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: already verified
• Risk associated with taking this patch: low
• Explanation of risk level: trivial fix
• String changes made/needed: none
• Is Android affected?: no

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9478845 [details]
Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=#release-managers

:dao can you take a look at the regression? Don't want to uplift if it is going to introduce new failures,

Comment 15

[Dão Gottwald [:dao]]

(In reply to Dianna Smith [:diannaS] from comment #14)

Comment on attachment 9478845 [details]
Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=#release-managers

:dao can you take a look at the regression? Don't want to uplift if it is going to introduce new failures,

Bug 1960102 you mean? That was from when this landed the first time in autoland (comment 4), fixed when it landed the second time (comment 7). The patch for uplift has the fix.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/57613eae9dfa

Comment 17

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 138.0b8