1953199 - Reword JSMSG_TEMPORAL_PLAIN_DATE_INVALID error message.

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

The JSMSG_TEMPORAL_PLAIN_DATE_INVALID is used to report invalid day, month or year fields to the user.

The current wording is "year-month-day must be valid iso dates", I think it would be more helpful to say "year-month-day must be valid ISO date values".

This is a good first bug, the main complexity will be getting the SpiderMonkey / Firefox build working.

1. Make sure you can build SpiderMonkey. You can find instructions on building here: https://firefox-source-docs.mozilla.org/js/build.html.
2. Change the error message, and then make sure the build is still working and you can run the tests. You might need to make some changes to the tests if they were expecting the old error message.
3. Now you can commit your changes. Your commit message should look like: Bug X - Reword JSMSG_TEMPORAL_PLAIN_DATE_INVALID error message; r=dminor!, where X is the number for this bug.
4. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[Luke Taylor [:ltaylor]]

Attachment: Bug 1953199 - Reword JSMSG_TEMPORAL_PLAIN_DATE_INVALID error message; r=dminor!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/288832407495
Reword JSMSG_TEMPORAL_PLAIN_DATE_INVALID error message; r=dminor

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/288832407495