Open Bug 1953245 Opened 9 months ago Updated 3 months ago

Default shortcut for sidebar expand is not working with Us International layout

Categories

(Firefox :: Sidebar, defect, P2)

Firefox 136
defect

Tracking

()

People

(Reporter: kiselt87, Unassigned, NeedInfo)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

I'm on Windows 11 pro, using an Us keyboard set to Us international layout because I need accented letters for my native language. Pressing default key combination does nothing. If I switch to Us standard layout the shortcut works as intended.

Actual results:

Using default Firefox shortcut with Us international layout print on screen "æ" grapheme and the sidebar is not expanding/hiding.

Expected results:

Sidebar should expand/hide as intended

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Sidebar

We have a similar bug filed in Screenshots in bug 1943791, and :masayuki has left some details in there on how to fix it.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
See Also: → 1943791

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

We have a similar bug filed in Screenshots in bug 1943791, and :masayuki has left some details in there on how to fix it.

It's not the same issue. The expand/collapse shortcut is using ctrl+alt which on some keyboard layouts is the same as AltGr, which is used for accented characters. This is why the shortcut prints a warning in the console "Key event not available on some keyboard layouts".

See Also: → 1936426

So then this would unfortunately be a "wont fix" because there isn't a solution other than changing the keyboard shortcut? Is there a meta for making shortcuts customizeable per your comment in bug 1936426 Gijs?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Sarah Clements [:sclements] from comment #4)

Is there a meta for making shortcuts customizeable per your comment in bug 1936426 Gijs?

bug 588710 and bug 492557 and bug 1215061. But AIUI there isn't a plan right now nor is it prioritized, and doing it isn't that easy.

So then this would unfortunately be a "wont fix" because there isn't a solution other than changing the keyboard shortcut?

Well, that part isn't really my call. :-)

Did we evaluate any of the shortcuts involving the function keys (F1-FNNN), perhaps with a modifier like shift or ctrl? I feel like those are underused in our shortcut system, but I don't know if there are other objections to the use of those keys, other than their unavailability on macOS laptops (but there, AIUI, we are not so bothered about other multi-modifier combinations, so maybe that ends up working out? I don't know.).

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(sclements)

(In reply to :Gijs (he/him) from comment #5)

(In reply to Sarah Clements [:sclements] from comment #4)

Is there a meta for making shortcuts customizeable per your comment in bug 1936426 Gijs?

bug 588710 and bug 492557 and bug 1215061. But AIUI there isn't a plan right now nor is it prioritized, and doing it isn't that easy.

So then this would unfortunately be a "wont fix" because there isn't a solution other than changing the keyboard shortcut?

Well, that part isn't really my call. :-)

Did we evaluate any of the shortcuts involving the function keys (F1-FNNN), perhaps with a modifier like shift or ctrl? I feel like those are underused in our shortcut system, but I don't know if there are other objections to the use of those keys, other than their unavailability on macOS laptops (but there, AIUI, we are not so bothered about other multi-modifier combinations, so maybe that ends up working out? I don't know.).

Sorry for the delay... Ania did a deep dive with the localization team to try to determine the best option based on availability. I'm not seeing function keys mentioned in that bug unless that's what Ania meant in this comment https://bugzilla.mozilla.org/show_bug.cgi?id=1897411#c9. I'll redirect to her in case she has anything to add.

Flags: needinfo?(sclements) → needinfo?(asafko)
See Also: → 1897411

This appears to be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1949304.

Duplicate of this bug: 1949304

(In reply to j. 'mach' wust from comment #7)

This appears to be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1949304.

Thanks. Although that bug is slightly older, it also got put under the Polish localization (translation) component, and I think a solution here actually has to come from Firefox's code, so I've duped that bug over to here instead of the other way around.

You need to log in before you can comment on or make changes to this bug.