1953285 - Incorrect message when taking a full page screenshot that's too large

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[el8]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

This is just a minor issue, but I thought I should report anyway.

1. Navigate to https://rbc.ru and press and hold Space till all the content is loaded.
2. Press F12 to open DevTools, enable the "Take screenshot of the entire page" button (a camera one) if it's not enabled yet.
3. Click on the button.

Actual results:

Firefox saves the screenshot and shows a message at the top of DevTools panel: "The image was cut off to 1263 x 10000 as the resulting image was too large".

Expected results:

The image is actually larger (3157 x 25000 on my machine) and the message should report correct screenshot limitations.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sam Foster [:sfoster] (he/him)]

This belongs in DevTools. Similar functionality but different string: https://searchfox.org/mozilla-central/search?q=The+image+was+cut+off&path=&case=false&regexp=false

Comment 3

[Julian Descottes [:jdescottes]]

We are probably not including the DPR in the error message.
Can be a good first bug, Nicolas will mentor this one.

Comment 4

[Rohit Borse]

I'm interested in working on it

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Rohit Borse from comment #4)

I'm interested in working on it

Thanks Rohit, the bug is now yours

The message comes from https://searchfox.org/mozilla-central/rev/126697140e711e04a9d95edae537541c3bde89cc/devtools/server/actors/utils/capture-screenshot.js#97

text: L10N.getFormatStr("screenshotTruncationWarning", width, height),

we should probably take the ratio in consideration https://searchfox.org/mozilla-central/rev/126697140e711e04a9d95edae537541c3bde89cc/devtools/server/actors/utils/capture-screenshot.js#150

const ratio = args.snapshotScale;

let me know if you have any question!

Comment 6

[Rohit Borse]

Attachment: Bug 1953285 - Incorrect message when taking a full page screenshot that's too large. r=Honza Incorrecty passing value of height and width in message - fixed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f50b03a25c70
Incorrect message when taking a full page screenshot that's too large. r=devtools-reviewers,nchevobbe Incorrecty passing value of height and width in message - fixed.

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f50b03a25c70