1953352 - Browser console crashes every time I click "Show/hide message details" next to network request log line

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[gwarser]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:138.0) Gecko/20100101 Firefox/138.0

Steps to reproduce:

-ctrl+shift+j
-enable multiprocess
-enable xhr and requests logging
-enable all settings under the cog wheel in top right
-re/load some page
-click the triangle before networks request line

Actual results:

The Console panel has crashed.
File Bug Report
TypeError: serviceContainer.getToolboxStore is not a function
React Component Stack

in MessageContainer

in LazyMessageList

in div

in ConsoleOutput

in Connect(ConsoleOutput)

in div

in div

in App

in Connect(App)

in AppErrorBoundary

in LocalizationProvider

in Provider

in Provider
Stacktrace

NetworkEventMessage@resource://devtools/client/webconsole/components/Output/message-types/NetworkEventMessage.js:205:35

render@resource://devtools/client/webconsole/components/Output/MessageContainer.js:79:12

finishClassComponent@resource://devtools/client/shared/vendor/react-dom.mjs:10634:31

updateClassComponent@resource://devtools/client/shared/vendor/react-dom.mjs:10597:44

beginWork@resource://devtools/client/shared/vendor/react-dom.mjs:11415:16

performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.mjs:14698:12

workLoop@resource://devtools/client/shared/vendor/react-dom.mjs:14716:24

renderRoot@resource://devtools/client/shared/vendor/react-dom.mjs:14799:15

performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.mjs:15651:17

performWork@resource://devtools/client/shared/vendor/react-dom.mjs:15563:24

performSyncWork@resource://devtools/client/shared/vendor/react-dom.mjs:15537:14

interactiveUpdates$1@resource://devtools/client/shared/vendor/react-dom.mjs:15804:7

interactiveUpdates@resource://devtools/client/shared/vendor/react-dom.mjs:1897:10

dispatchInteractiveEvent@resource://devtools/client/shared/vendor/react-dom.mjs:4324:21

Close and reopen the toolbox to clear this error.

Expected results:

See request details

Comment 1

[gwarser]

Build ID 20250311212727

Comment 2

[gwarser]

The "File Bug Report" button does not work.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Julian Descottes [:jdescottes]]

Oh right that must be from Bug 1849920.

I am not adding the method to the serviceContainer when there is no toolbox, which is the case for the browser console.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849920

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1953352 - [devtools] Fix the network Tabbox in the Browser Console

The toolbox store is not available in the Browser Console.
The netmonitor's TabboxPanel component now exports two variants:

• TabboxPanel: raw TabboxPanel without toolbox store derived props
• ConnectedTabboxPanel: connected to the toolbox store for override props

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c33a898aae09
[devtools] Fix the network Tabbox in the Browser Console r=nchevobbe,devtools-reviewers

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1953352 - [devtools] Fix the network Tabbox in the Browser Console

The toolbox store is not available in the Browser Console.
The netmonitor's TabboxPanel component now exports two variants:

• TabboxPanel: raw TabboxPanel without toolbox store derived props
• ConnectedTabboxPanel: connected to the toolbox store for override props

Original Revision: https://phabricator.services.mozilla.com/D241159

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Browser Console shows error screen when clicking on a network request
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: Low
• Explanation of risk level: Simple JS fix, covered with automated tests, devtools only
• String changes made/needed: -
• Is Android affected?: no

Comment 10

[gwarser]

Can you tell me, the "File Bug Report" button is doing something for you? Does nothing for me. Will it be fixed here?

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c33a898aae09

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

(In reply to gwarser from comment #10)

Can you tell me, the "File Bug Report" button is doing something for you? Does nothing for me. Will it be fixed here?

It's going to be fixed as part of Bug 1953384 (a patch was pushed already, should be in tomorrow's Nightly)

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/24429ce623e6