Closed
Bug 1953376
Opened 6 months ago
Closed 6 months ago
Gutter border is not visible in dark HCM
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox138 fixed)
RESOLVED
FIXED
138 Branch
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In dark mode, we're using --theme-toolbar-background, but in high Contrast Mode, it's not different from the background we use, making it not visible https://searchfox.org/mozilla-central/rev/b0e8e4ceb46cb3339cdcb90310fcc161ef4b9e3e/devtools/client/themes/dark-theme.css#270,272,274
.cm-s-mozilla .CodeMirror-gutters,
...
border-right-color: var(--theme-toolbar-background);
...
}
|
Assignee | |
Comment 1•6 months ago
|
||
Move rule for gutters from (light|dark)-theme.css to mozilla.css, use variable for the
background and border colors, and redefine the border in High Contrast Mode.
|
||
Updated•6 months ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
||
Updated•6 months ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24737ee87fbb
[devtools] Fix Debugger gutter border in High Contrast Mode. r=devtools-reviewers,ochameau.
|
||
Comment 3•6 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•