1953429 - encode_kind == SEC_ASN1_INLINE && !optional, at ../../lib/util/secasn1d.c:584

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Maurice Dauer [:mdauer]]

The ASN1 decoder does not support templates using SEC_ASN1_INLINE together with SEC_ASN1_OPTIONAL. Remove those templates from the asn1 fuzz target.

Comment 1

[Maurice Dauer [:mdauer]]

Attachment: Bug 1953429 - Remove CERT_CrlTemplate from ASN1 fuzz target, r?#nss-reviewers

The ASN1 decoder does not support templates that use SEC_ASN1_INLINE and SEC_ASN1_OPTIONAL together.

Comment 2

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/6612482545d61e6ffabe05ffae272c285092a099

Comment 3

[Maurice Dauer [:mdauer]]

Attachment: Bug 1953429 - Remove Crl templates from ASN1 fuzz target, r?#nss-reviewers

The ASN1 decoder does not support templates that use SEC_ASN1_INLINE and SEC_ASN1_OPTIONAL together. These are used by the QuickDER fuzz target.

Comment 4

[Maurice Dauer [:mdauer]]

https://hg.mozilla.org/projects/nss/rev/fb4859ea0147c2f1ceb74d3f5a15646d71ab9edd

Comment 5

[Kai Engert [:KaiE:]]

Why did you consider it a sufficient fix to simply remove the template from fuzzing?

Is it because these templates are never used with the secasn1d decoder?

Comment 6

[Maurice Dauer [:mdauer]]

Yeah, I found Bug 289649 which states:

[...] CRLs are normally decoded with the QuickDER decode, which supports this syntax without limitations.

I looked through searchfox and couldn't find CRL templates used with the ASN1 decoder, thus figured it should be fine to remove them. We use these templates in the QuickDER decoder fuzz target.