1953487 - Add keywords for themes quickaction

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Dale Harvey (:daleharvey)]

New keywords: addons, add-ons, add ons

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1953487 - Update themes keywords including ability to match multiple keywords. r=daisuke

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:daleharvey, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45e5efa89a8d
https://hg.mozilla.org/integration/autoland/rev/fa1d73a59dcd
Update themes keywords including ability to match multiple keywords. r=daisuke,fluent-reviewers,urlbar-reviewers,flod

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/65d551100b8a
https://hg.mozilla.org/integration/autoland/rev/6d90930cf1d9
Revert "Bug 1953487 - Update themes keywords including ability to match multiple keywords. r=daisuke,fluent-reviewers,urlbar-reviewers,flod" for causing bc process crashes

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing bc process crashes

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5058f18c4ef4
https://hg.mozilla.org/integration/autoland/rev/18e6b65b916c
Update themes keywords including ability to match multiple keywords. r=daisuke,fluent-reviewers,urlbar-reviewers,flod

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/18e6b65b916c

Comment 8

[Dale Harvey (:daleharvey)]

Clearing needinfo

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Issue is verified fixed using Fx 142.0a1 on Windows, macOS and Ubuntu 24.04. "addons" and "add-ons" correctly trigger the quick action and redirect the user when clicked. Please note however that "add ons", even though specified, was not added to the list of keywords, but according to engineering that was intentional.