1953530 - Refactor Nimbus Telemetry into a common module

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, task, P1)

Description

[Beth Rennie [:beth] (she/her)]

There's telemetry code spread across all of Nimbus. It would be nice if it was consolidated into one place that defined all the different types of telemetry we collect. Then we could also make it easier to do bug 1947901 as all the definitions would be in one place and could be referenced from all of Nimbus client code.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1953530 - Move most Nimbus telemetry code into a single module r?#nimbus-reviewers

This patch does not change the targeting context telemetry as it is
sufficiently complicated and isolated from the rest of the telemetry.

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1953530 - Use invalid-feature for enrollment_status and validation_failed telemetry r?chumphreys

validation_failed mistakenly listed the reason as invalid-reason (a
typo) and enrollment_status was lumping invalid-feature errors under
invalid-branch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed419e286e98
Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys
https://hg.mozilla.org/integration/autoland/rev/e15c1f236b84
Use invalid-feature for enrollment_status and validation_failed telemetry r=chumphreys

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/f31868a8422c30fcae5963a72cf8ba9ea9b3816a

Push with failures

Failure log -> ERROR - gmake[3]: *** [backend.mk:2033: toolkit/components/glean/.deps/metrics_yamls.cached.stub] Error 1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20a465730ec2
Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys
https://hg.mozilla.org/integration/autoland/rev/97d32cd5c863
Use invalid-feature for enrollment_status and validation_failed telemetry r=chumphreys

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpc/bc failures @ test_ExperimentManager_unenroll.js & browser_asrouter_experimentsAPILoader.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/93e27172c9069212ec1a784c098e5b6ffa11903f

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/unit/test_ExperimentManager_unenroll.js

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/asrouter/tests/browser/browser_asrouter_experimentsAPILoader.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc38ba906d3f
Use invalid-feature for enrollment_status and validation_failed telemetry r=chumphreys
https://hg.mozilla.org/integration/autoland/rev/40e98c849875
Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys,omc-reviewers,aminomancer

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_asrouter_experimentsAPILoader.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/asrouter/tests/browser/browser_asrouter_experimentsAPILoader.js | Uncaught exception in test bound test_exposure_ping - at resource://testing-common/sinon-7.2.7.js:3637 - TypeError: Attempted to wrap undefined property recordExposureEvent as function

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535341605cd2
Use invalid-feature for enrollment_status and validation_failed telemetry r=chumphreys
https://hg.mozilla.org/integration/autoland/rev/fcda25256bee
Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys,omc-reviewers,aminomancer

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/535341605cd2
https://hg.mozilla.org/mozilla-central/rev/fcda25256bee