1953622 - Flood of -Ddangling-pointer warning messages

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P2)

Description

[Steve Fink [:sfink] [:s:]]

Later versions of gcc complain about a dangling pointer in the Rooted constructor (from persistently storing a stack pointer).

None of our current compiler versions run into this yet. I accidentally hit it because I had forgotten that one of my mozconfigs has CC=gcc in it, which used my system gcc12.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1953622 - Suppress -Wdangling-pointer warning when storing a Rooted address

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405ec783a205
Suppress -Wdangling-pointer warning when storing a Rooted address r=spidermonkey-reviewers,jonco

Comment 3

[agoloman]

Backed out for causing build bustages @RootingAPI.h. CLOSED TREE

• Backout link
• Push with failures
• Failure Log

Comment 4

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c04f0228562
Suppress -Wdangling-pointer warning when storing a Rooted address r=spidermonkey-reviewers,jonco

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/5c04f0228562