Closed Bug 1953766 Opened 5 months ago Closed 5 months ago

[wpt-sync] Sync PR 51317 - corner-shape: use real superellipse as reference

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51317 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51317
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

corner-shape: use real superellipse as reference

Use a superellipse formula instead of bezier approximation for
creating the corner-shape references.
This ensures that we're honest about what we render.

Since the bezier version is an approximation, the fuzz factor
needs to be pretty high and the radii need to be pretty low.

We can iteratively try to improve the formula and reduce the fuzz
as we move forward.

Note that the test is ported from a prototype, and include
border rendering that is not utilized yet.

This exposed issues with how the approximation renders concave shapes,
opened https://issues.chromium.org/issues/402910367 and removed them
from the variants until fixed.

R=pdr

Bug: 394059604
Change-Id: I8f45b88f20ba5b9d9cb1474c8939400b53f68457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349037
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1432033}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests

Status Summary

Firefox

PASS: 1
FAIL: 9

Chrome

PASS: 10

Safari

PASS: 1
FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d85085d77cdd [wpt PR 51317] - corner-shape: use real superellipse as reference, a=testonly https://hg.mozilla.org/integration/autoland/rev/645b0ff92602 [wpt PR 51317] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d85085d77cdd
https://hg.mozilla.org/mozilla-central/rev/645b0ff92602

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.