1953818 - [wpt-sync] Sync PR 51322 - Check whether an element is custom in the spec-compliant way

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51322 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51322
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Check whether an element is custom in the spec-compliant way

Current code checks whether an element is custom by checking whether it has an associated custom element definition. This is different from the spec, which says:

An element whose custom element state is "custom" is said to be custom.

The two definitions are identical in almost all cases, except during custom element upgrade, where the custom element state is set to failed until finished.

As a result, the current implementation may erroneously fire custom element callbacks for mutations during the upgrade.

This PR fixes it.

Reviewed in servo/servo#35960

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a496eda65e73b1717c8bb16ed566061b4fc0157e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 6

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6be449c446b
[wpt PR 51322] - Check whether an element is custom in the spec-compliant way, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a6be449c446b