1953927 - Address bar dropdown is not dismissed after opening USB and then clicking outside

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Petruta Horea [:phorea]]

Found in

• Nightly 138.0a1;

Affected versions

• Firefox Nightly 138.0a1;
• Firefox 137 beta 5;

Affected platforms

• macOS 14;
• Ubuntu 24;

Unaffected platforms

• Windows 10;

Steps to reproduce

1. Open a new tab and click on the address bar
2. Click on the Unified Search Button to open the dropdown.
3. Click outside to dismiss the USB dropdown.

Expected result

• Clicking on page content dismisses the USB dropdown, no other dropdowns should be visible.

Actual result

• Address bar dropdown is reopened.

Regression range

• last good: 2025-02-12;
• first bad: 2025-02-13;
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c695e81404d9c569838b59ddd3a5ba77df87f03&tochange=a3ddc7278467e7fdc06ba96e92ff883aba52b208
• regressed by: bug 1934410

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1934410, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1953927: Close urlbar view explicitly when opening Unified Search Engine popup

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dfd7b14198d
Close urlbar view explicitly when opening Unified Search Engine popup r=desktop-theme-reviewers,daleharvey,dao

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing searchModeSwitcher related failures

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86a4891408c7
Close urlbar view explicitly when opening Unified Search Engine popup r=desktop-theme-reviewers,daleharvey,dao

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/86a4891408c7

Comment 7

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9471922 [details]
Bug 1953927: Close urlbar view explicitly when opening Unified Search Engine popup

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Urlbar result will be reopened automatically unexpectedly if closing the Unified Search engine popup by clicking outside of the popup.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch changes only the behavior of after clicking outside of the popup.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 8

[Pascal Chevrel:pascalc]

S2 definition:
(Serious) Major functionality/product severely impaired or a high impact issue and a satisfactory workaround does not exist

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cbb58c17229c

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-03-13 Firefox Nightly build on macOS 14.
Verified as fixed on Firefox Nightly 138.0a1 and Firefox 137.0 on macOS 14 and Ubuntu 22.
Address bar dropdown does not re-open after dismissing the USB dropdown.