1953964 - Show the precise location and column where the debugger paused

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

For now, we don't highlight precisely the column of the paused location.
We do highlight the first token after the paused location, but that isn't super explicit.
It would be nice to have something shown at the precise column where the debugger is paused.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953964 - [devtools] Show the precise location and column where the debugger paused.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953964 - [devtools] Prevent showing the pause location information until the related source is actually displayed.

In mapStateToProps, for CM5, we used to wait for the source to be actually rendered in CodeMirror via hasDocument call.
This is actually a miss for CM6 as we may try to render the pause location UIs while we are still on the "Loading..." text in CodeMirror.
Also, hasDocument was brittle as this isn't a selector and may not necessarily trigger a state change.
So start using viewport selector as it should ultimately be updated and trigger mapStateToProps whenever it is defined.

Also tweak the source editor to ensure returning a viewport only when an actual source is displayed,
and return null when showing "Loading..." as well as error messages.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953964 - [devtools] Stop highlighting the next token after the paused location.

This is now redundant with the new paused caret UI and can be confusing.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953964 - [devtools] Fix highlighting the hovered token on the paused line.

We were using the same background color for the hovered token and the paused line.

Comment 5

[Phabricator Automation]

Comment on attachment 9474628 [details]
Bug 1953964 - [devtools] Prevent showing the pause location information until the related source is actually displayed.

Revision D243089 was moved to bug 1957352. Setting attachment 9474628 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9474630 [details]
Bug 1953964 - [devtools] Fix highlighting the hovered token on the paused line.

Revision D243091 was moved to bug 1957343. Setting attachment 9474630 [details] to obsolete.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1953964 - [devtools] Inline the paused reason next to the paused line.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b547efafb342
[devtools] Stop highlighting the next token after the paused location. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/044c52a63277
[devtools] Show the precise location and column where the debugger paused. r=devtools-reviewers,nchevobbe

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b547efafb342
https://hg.mozilla.org/mozilla-central/rev/044c52a63277