Closed
Bug 1953971
Opened 1 year ago
Closed 1 year ago
Calls to `BrowserTestUtils.addTab` in the Tabbed Browser component do not need to be awaited
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
138 Branch
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: scunnane, Assigned: chris.shiohama, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
I noticed several calls to BrowserTestUtils.addTab in browser/components/tabbrowser/test/browser/tabs/browser_ctrlTab.js that are awaited. However they don't need to be, as BrowserTestUtils.addTab doesn't return a promise. Cleaning up these calls would be a good first bug for a contributor.
|
Reporter | |
Updated•1 year ago
|
Summary: Calls to `BrowserTestUtils.addTab` do not need to be awaited → Calls to `BrowserTestUtils.addTab` in the Tabbed Browser component do not need to be awaited
|
|
Reporter | |
Updated•1 year ago
|
Mentor: scunnane
|
|
Reporter | |
Updated•1 year ago
|
Assignee: nobody → joel.mozillaosi
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
Stephanie, are there any tests I should run?
Flags: needinfo?(scunnane)
|
|
Reporter | |
Comment 3•1 year ago
|
||
Hi Chris, you can run $ ./mach mochitest browser/components/tabbrowser/test/browser/tabs/browser_ctrlTab.js --headless
Flags: needinfo?(scunnane)
|
||
Updated•1 year ago
|
Attachment #9472480 -
Attachment description: WIP: Bug 1953971 - Calls to in the Tabbed Browser component do not need to be awaited → WIP: Bug 1953971 - Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited
|
|
||
Updated•1 year ago
|
Attachment #9472480 -
Attachment description: WIP: Bug 1953971 - Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited → Bug 1953971 - Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited. r?mconley!
|
|
Reporter | |
Updated•1 year ago
|
Assignee: joel.mozillaosi → chris.shiohama
Pushed by scunnane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/273cf9d2127b
Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited. r=scunnane
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•